Home
Creators
Search Recent Random
Posts
Search DMs Popular Hash Lookup Tags Random
Importer
Import FAQ
Register Favorites Keys Review DMs Logout
Community
Telegram ThePornDude
Home Creators Posts Import Register Favorites Logout

He wrote this out BY HAND? // Full Code Review (Patreon)

Published:
2024-10-18 06:43:12
Edited:
2024-10-18 10:31:26
Imported:
2026-06
Tags:

Downloads

  • 367194743.mp4

Some files exceed the archive size limit and weren't saved: 1 video. Please note these limits are in place to keep this site running long term, without costing a fortune. You can favorite the creator though, certain milestones increase the limit.

Content

Hey all! Trying something new here - longer more in-depth code reviews just for you Patrons! Let me know what you thought of this video, and if you have any follow up questions, I'll take a look for the next video.

And of course, if you have any code of your own you'd like me to review, send it in to chernoreview@gmail.com and mention that you're a Patron in the subject, and I'll do my best to review it. Thank you so much for your support! ❤️

Here's the code from this video ► https://github.com/sorumehta/skyward-scammer

Files

Comments

Saurabh Mehta

I appreciate the effort you put in to debug the SDL_main issue, I never encountered it on my Mac. Yeah there are a lot of inconsistencies, due to me being in learning phase of C++ and learning from different tutorials. As for how the in depth review was, I liked it, but might be biased :P btw, the Pseudo3D is inspired from OneLoneCoder's Mario Kart game

Tom Conder

Some of the odd decisions for names may be the influence of javidx9's OLC game engine. My advice is to use a linter such as clang-tidy. It will identify improvements that can be made, i.e. static fields and raw pointers. Your IDE may even be able to quick fix issues it finds. Please look into using a package manager such as vcpkg. Even though it is maintained by Microsoft it runs nicely on Windows, Mac and Linux and integrates easily into CMake. Once set up, when you call find_library() it looks for packages in your local vcpkg repository and downloads them when necessary. Cherno: I feel that you've given this code adequate review. My vote is to move on.

Petr Seifert

I really liked this in-depth review. I hope you will continue to do them.

naaaterino

I have never written a line of code in C++, and I don't ever intend on making a game, but I enjoy the way you explain stuff. Really enjoyed the video. I'm listening while playing Factorio DLC, so you could make this 2x as long and I would enjoy it. Also it might be helpful to people who are thinking about subbing to mention how much longer this video is than the youtube version.

Mitch Andrews

you spent a decent amount of time on the CMAKE portion of this, what do you think of Sharpmake? I think that would make an excellent video for doing a deep dive on it and basic setup. I've been using it for a few years now and absolutely love it since you can also debug your project generation as well!

James Palermo

I think on Patreon I’d prefer the extra time being spent less on line by line refactoring and rapid commentary and see some more in depth drilling down on the fundamental motivation behind design mistakes or changes you feel are important. For example with the section of array members for sprites: I now know consistency between vec and array is important, it’s better to just have the engine pull in from a folder, and I should never use strings for file paths. But why exactly… I’m not sure. Basically whenever you have said something like “I don’t even know if this is worth going into” or “this is probably beyond the scope” that’s when I’m like “Yes it is worth it! Go into it!” Use the review framing as a launching pad to teach concepts. TBH an hour of context-shifting around a code base doing refactoring advice is a bit much.

Sluggo

Love the in-depth code review, I usually watch videos at 1.25X, yours I have to watch at 0.75X (you sound kind of drunk but that's fine) so I can keep up. I think you pretty much hit the mark on this one.

Gear2ndGandalf

@15:20 “Cheating with Gonzo” was a bad idea? Sounds like your wife walked in on you cheating lol.